Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

support vertical writing modes #141

Merged
merged 4 commits into from
Jun 4, 2024
Merged

support vertical writing modes #141

merged 4 commits into from
Jun 4, 2024

Conversation

eagleoflqj
Copy link
Member

@eagleoflqj eagleoflqj commented Jun 3, 2024 •
edited
Loading

Known issues:

  • Some emojis are rotated and some not. A WebKit issue that I'm not going to hack.
  • Horizontal layout + Vertical writing mode may lead to wrong multi-character candidate's layout that is corrected on drag. Use it as-is and it's not worth investigation.

Please update submodule on merge.

@eagleoflqj eagleoflqj requested a review from ksqsf June 3, 2024 22:08
ksqsf
ksqsf approved these changes Jun 4, 2024
View reviewed changes
Copy link
Member

@ksqsf ksqsf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I made some further changes. PTAL

@ksqsf ksqsf merged commit 6816bd2 into master Jun 4, 2024
4 checks passed
@ksqsf ksqsf deleted the writing-mode branch June 4, 2024 11:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ksqsf ksqsf ksqsf approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@eagleoflqj @ksqsf